Show improved Dax onboarding on New Tab Page #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
force-pushed
the
mariusz/ntp-integrate-onboarding
branch
from
6e29ee4 to
2edc4a9
Compare
dus7
force-pushed
the
mariusz/ntp-integrate-onboarding
branch
from
2edc4a9 to
8a14f59
Compare
dus7
commented
Aug 7, 2024
Comment on lines
+202
to
+230
| func showNextDaxDialogNew(dialogProvider: NewTabDialogSpecProvider, factory: any NewTabDaxDialogProvider) { | ||
| dismissHostingController(didFinishNTPOnboarding: false) | ||
|
|
||
| guard let spec = dialogProvider.nextHomeScreenMessageNew() else { return } | ||
|
|
||
| let onDismiss = { | ||
| dialogProvider.dismiss() | ||
| self.dismissHostingController(didFinishNTPOnboarding: true) | ||
| } | ||
| let daxDialogView = AnyView(factory.createDaxDialog(for: spec, onDismiss: onDismiss)) | ||
| let hostingController = UIHostingController(rootView: daxDialogView) | ||
| self.hostingController = hostingController | ||
|
|
||
| hostingController.view.backgroundColor = .clear | ||
| addChild(hostingController) | ||
| view.addSubview(hostingController.view) | ||
| hostingController.view.translatesAutoresizingMaskIntoConstraints = false | ||
|
|
||
| NSLayoutConstraint.activate([ | ||
| hostingController.view.topAnchor.constraint(equalTo: view.topAnchor), | ||
| hostingController.view.leadingAnchor.constraint(equalTo: view.leadingAnchor), | ||
| hostingController.view.trailingAnchor.constraint(equalTo: view.trailingAnchor), | ||
| hostingController.view.bottomAnchor.constraint(equalTo: view.bottomAnchor) | ||
| ]) | ||
|
|
||
| hostingController.didMove(toParent: self) | ||
|
|
||
| newTabPageModel.startOnboarding() | ||
| } |
There was a problem hiding this comment.
Copied the code from HomeViewController+DaxDialogs, but included addChild(hostingController) which was missing in the original.
There was a problem hiding this comment.
Included this call in the HomeViewController code (cd424a9).
alessandroboron
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
This works as expected! As we will be removing HomeViewController altogether it’s fine if we have temporary duplicate code to initialise the HostingController for the dax dialogs view. Thanks @dus7!
samsymons
added a commit
that referenced
this pull request
Aug 12, 2024
# By Sam Symons (3) and others # Via Chris Brind (2) and others * main: DuckPlayer contingency messages pixels (#3220) New autofill onboarding for existing DDG users (#3170) Add translations for DuckPlayer contingency messge (#3215) Fix PrivacyProDataReporter crash due to premature secure vault use (#3217) Bump rexml from 3.2.9 to 3.3.3 (#3175) Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3165) [DuckPlayer] 16. Localization Updates (#3200) Release 7.132.0-3 (#3213) cherry pick temporary fix for https://app.asana.com/0/414235014887631/1207990702991361/f fix content inset when keyboard is visible (#3207) Ship review feedback for contingency message (#3209) Release 7.132.0-2 (#3211) Restore attribution flag (#3197) Restore attribution flag (#3197) Release 7.132.0-1 (#3208) Break DuckPlayer ref cycle (#3206) Show improved Dax onboarding on New Tab Page (#3203) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207981662892269/f
Tech Design URL:
CC: @alessandroboron @SabrinaTardio
Description:
Integration of the new (improved) onboarding with New Tab Page. Previous Dax onboarding is not integrated since it will be removed after the experiment. NTP will start to roll out after the onboarding experiment is concluded.
Steps to test this PR:
DefaultVariantManagerso.newOnboardingIntrois always enabled.NewTabPageManager.isNewTabPageSectionsEnabledso it returnstrue.Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template